test_malformed_sigs.py 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378
  1. from __future__ import with_statement, division
  2. import hashlib
  3. try:
  4. from hashlib import algorithms_available
  5. except ImportError: # pragma: no cover
  6. algorithms_available = [
  7. "md5",
  8. "sha1",
  9. "sha224",
  10. "sha256",
  11. "sha384",
  12. "sha512",
  13. ]
  14. # skip algorithms broken by change to OpenSSL 3.0 and early versions
  15. # of hashlib that list algorithms that require the legacy provider to work
  16. # https://bugs.python.org/issue38820
  17. algorithms_available = [
  18. i
  19. for i in algorithms_available
  20. if i not in ("mdc2", "md2", "md4", "whirlpool", "ripemd160")
  21. ]
  22. from functools import partial
  23. import pytest
  24. import sys
  25. import hypothesis.strategies as st
  26. from hypothesis import note, assume, given, settings, example
  27. from .keys import SigningKey
  28. from .keys import BadSignatureError
  29. from .util import sigencode_der, sigencode_string
  30. from .util import sigdecode_der, sigdecode_string
  31. from .curves import curves, SECP112r2, SECP128r1
  32. from .der import (
  33. encode_integer,
  34. encode_bitstring,
  35. encode_octet_string,
  36. encode_oid,
  37. encode_sequence,
  38. encode_constructed,
  39. )
  40. from .ellipticcurve import CurveEdTw
  41. example_data = b"some data to sign"
  42. """Since the data is hashed for processing, really any string will do."""
  43. hash_and_size = [
  44. (name, hashlib.new(name).digest_size) for name in algorithms_available
  45. ]
  46. """Pairs of hash names and their output sizes.
  47. Needed for pairing with curves as we don't support hashes
  48. bigger than order sizes of curves."""
  49. if "--fast" in sys.argv: # pragma: no cover
  50. curves = [SECP112r2, SECP128r1]
  51. keys_and_sigs = []
  52. """Name of the curve+hash combination, VerifyingKey and DER signature."""
  53. # for hypothesis strategy shrinking we want smallest curves and hashes first
  54. for curve in sorted(curves, key=lambda x: x.baselen):
  55. for hash_alg in [
  56. name
  57. for name, size in sorted(hash_and_size, key=lambda x: x[1])
  58. if 0 < size <= curve.baselen
  59. ]:
  60. sk = SigningKey.generate(
  61. curve, hashfunc=partial(hashlib.new, hash_alg)
  62. )
  63. keys_and_sigs.append(
  64. (
  65. "{0} {1}".format(curve, hash_alg),
  66. sk.verifying_key,
  67. sk.sign(example_data, sigencode=sigencode_der),
  68. )
  69. )
  70. # first make sure that the signatures can be verified
  71. @pytest.mark.parametrize(
  72. "verifying_key,signature",
  73. [pytest.param(vk, sig, id=name) for name, vk, sig in keys_and_sigs],
  74. )
  75. def test_signatures(verifying_key, signature):
  76. assert verifying_key.verify(
  77. signature, example_data, sigdecode=sigdecode_der
  78. )
  79. @st.composite
  80. def st_fuzzed_sig(draw, keys_and_sigs): # pragma: no cover
  81. """
  82. Hypothesis strategy that generates pairs of VerifyingKey and malformed
  83. signatures created by fuzzing of a valid signature.
  84. """
  85. name, verifying_key, old_sig = draw(st.sampled_from(keys_and_sigs))
  86. note("Configuration: {0}".format(name))
  87. sig = bytearray(old_sig)
  88. # decide which bytes should be removed
  89. to_remove = draw(
  90. st.lists(st.integers(min_value=0, max_value=len(sig) - 1), unique=True)
  91. )
  92. to_remove.sort()
  93. for i in reversed(to_remove):
  94. del sig[i]
  95. note("Remove bytes: {0}".format(to_remove))
  96. # decide which bytes of the original signature should be changed
  97. xors = None
  98. if sig: # pragma: no branch
  99. xors = draw(
  100. st.dictionaries(
  101. st.integers(min_value=0, max_value=len(sig) - 1),
  102. st.integers(min_value=1, max_value=255),
  103. )
  104. )
  105. for i, val in xors.items():
  106. sig[i] ^= val
  107. note("xors: {0}".format(xors))
  108. # decide where new data should be inserted
  109. insert_pos = draw(st.integers(min_value=0, max_value=len(sig)))
  110. # NIST521p signature is about 140 bytes long, test slightly longer
  111. insert_data = draw(st.binary(max_size=256))
  112. sig = sig[:insert_pos] + insert_data + sig[insert_pos:]
  113. note(
  114. "Inserted at position {0} bytes: {1!r}".format(insert_pos, insert_data)
  115. )
  116. sig = bytes(sig)
  117. # make sure that there was performed at least one mutation on the data
  118. assume(to_remove or xors or insert_data)
  119. # and that the mutations didn't cancel each-other out
  120. assume(sig != old_sig)
  121. return verifying_key, sig
  122. params = {}
  123. # not supported in hypothesis 2.0.0
  124. if sys.version_info >= (2, 7): # pragma: no branch
  125. from hypothesis import HealthCheck
  126. # deadline=5s because NIST521p are slow to verify
  127. params["deadline"] = 5000
  128. params["suppress_health_check"] = [
  129. HealthCheck.data_too_large,
  130. HealthCheck.filter_too_much,
  131. HealthCheck.too_slow,
  132. ]
  133. if "--fast" in sys.argv: # pragma: no cover
  134. params["max_examples"] = 20
  135. slow_params = dict(params)
  136. if "--fast" in sys.argv: # pragma: no cover
  137. slow_params["max_examples"] = 1
  138. else:
  139. slow_params["max_examples"] = 10
  140. @settings(**slow_params)
  141. @given(st_fuzzed_sig(keys_and_sigs))
  142. def test_fuzzed_der_signatures(args):
  143. verifying_key, sig = args
  144. with pytest.raises(BadSignatureError):
  145. verifying_key.verify(sig, example_data, sigdecode=sigdecode_der)
  146. @st.composite
  147. def st_random_der_ecdsa_sig_value(draw): # pragma: no cover
  148. """
  149. Hypothesis strategy for selecting random values and encoding them
  150. to ECDSA-Sig-Value object::
  151. ECDSA-Sig-Value ::= SEQUENCE {
  152. r INTEGER,
  153. s INTEGER
  154. }
  155. """
  156. name, verifying_key, _ = draw(st.sampled_from(keys_and_sigs))
  157. note("Configuration: {0}".format(name))
  158. order = int(verifying_key.curve.order)
  159. # the encode_integer doesn't support negative numbers, would be nice
  160. # to generate them too, but we have coverage for remove_integer()
  161. # verifying that it doesn't accept them, so meh.
  162. # Test all numbers around the ones that can show up (around order)
  163. # way smaller and slightly bigger
  164. r = draw(
  165. st.integers(min_value=0, max_value=order << 4)
  166. | st.integers(min_value=order >> 2, max_value=order + 1)
  167. )
  168. s = draw(
  169. st.integers(min_value=0, max_value=order << 4)
  170. | st.integers(min_value=order >> 2, max_value=order + 1)
  171. )
  172. sig = encode_sequence(encode_integer(r), encode_integer(s))
  173. return verifying_key, sig
  174. @settings(**slow_params)
  175. @given(st_random_der_ecdsa_sig_value())
  176. def test_random_der_ecdsa_sig_value(params):
  177. """
  178. Check if random values encoded in ECDSA-Sig-Value structure are rejected
  179. as signature.
  180. """
  181. verifying_key, sig = params
  182. with pytest.raises(BadSignatureError):
  183. verifying_key.verify(sig, example_data, sigdecode=sigdecode_der)
  184. def st_der_integer(*args, **kwargs): # pragma: no cover
  185. """
  186. Hypothesis strategy that returns a random positive integer as DER
  187. INTEGER.
  188. Parameters are passed to hypothesis.strategy.integer.
  189. """
  190. if "min_value" not in kwargs: # pragma: no branch
  191. kwargs["min_value"] = 0
  192. return st.builds(encode_integer, st.integers(*args, **kwargs))
  193. @st.composite
  194. def st_der_bit_string(draw, *args, **kwargs): # pragma: no cover
  195. """
  196. Hypothesis strategy that returns a random DER BIT STRING.
  197. Parameters are passed to hypothesis.strategy.binary.
  198. """
  199. data = draw(st.binary(*args, **kwargs))
  200. if data:
  201. unused = draw(st.integers(min_value=0, max_value=7))
  202. data = bytearray(data)
  203. data[-1] &= -(2**unused)
  204. data = bytes(data)
  205. else:
  206. unused = 0
  207. return encode_bitstring(data, unused)
  208. def st_der_octet_string(*args, **kwargs): # pragma: no cover
  209. """
  210. Hypothesis strategy that returns a random DER OCTET STRING object.
  211. Parameters are passed to hypothesis.strategy.binary
  212. """
  213. return st.builds(encode_octet_string, st.binary(*args, **kwargs))
  214. def st_der_null(): # pragma: no cover
  215. """
  216. Hypothesis strategy that returns DER NULL object.
  217. """
  218. return st.just(b"\x05\x00")
  219. @st.composite
  220. def st_der_oid(draw): # pragma: no cover
  221. """
  222. Hypothesis strategy that returns DER OBJECT IDENTIFIER objects.
  223. """
  224. first = draw(st.integers(min_value=0, max_value=2))
  225. if first < 2:
  226. second = draw(st.integers(min_value=0, max_value=39))
  227. else:
  228. second = draw(st.integers(min_value=0, max_value=2**512))
  229. rest = draw(
  230. st.lists(st.integers(min_value=0, max_value=2**512), max_size=50)
  231. )
  232. return encode_oid(first, second, *rest)
  233. def st_der(): # pragma: no cover
  234. """
  235. Hypothesis strategy that returns random DER structures.
  236. A valid DER structure is any primitive object, an octet encoding
  237. of a valid DER structure, sequence of valid DER objects or a constructed
  238. encoding of any of the above.
  239. """
  240. return st.recursive( # pragma: no branch
  241. st.just(b"")
  242. | st_der_integer(max_value=2**4096)
  243. | st_der_bit_string(max_size=1024**2)
  244. | st_der_octet_string(max_size=1024**2)
  245. | st_der_null()
  246. | st_der_oid(),
  247. lambda children: st.builds(encode_octet_string, st.one_of(children))
  248. | st.builds(lambda x: encode_bitstring(x, 0), st.one_of(children))
  249. | st.builds(
  250. lambda x: encode_sequence(*x), st.lists(children, max_size=200)
  251. )
  252. | st.builds(
  253. encode_constructed,
  254. st.integers(min_value=0, max_value=0x3F),
  255. st.one_of(children),
  256. ),
  257. max_leaves=40,
  258. )
  259. @settings(**slow_params)
  260. @given(st.sampled_from(keys_and_sigs), st_der())
  261. def test_random_der_as_signature(params, der):
  262. """Check if random DER structures are rejected as signature"""
  263. name, verifying_key, _ = params
  264. with pytest.raises(BadSignatureError):
  265. verifying_key.verify(der, example_data, sigdecode=sigdecode_der)
  266. @settings(**slow_params)
  267. @given(st.sampled_from(keys_and_sigs), st.binary(max_size=1024**2))
  268. @example(
  269. keys_and_sigs[0], encode_sequence(encode_integer(0), encode_integer(0))
  270. )
  271. @example(
  272. keys_and_sigs[0],
  273. encode_sequence(encode_integer(1), encode_integer(1)) + b"\x00",
  274. )
  275. @example(keys_and_sigs[0], encode_sequence(*[encode_integer(1)] * 3))
  276. def test_random_bytes_as_signature(params, der):
  277. """Check if random bytes are rejected as signature"""
  278. name, verifying_key, _ = params
  279. with pytest.raises(BadSignatureError):
  280. verifying_key.verify(der, example_data, sigdecode=sigdecode_der)
  281. keys_and_string_sigs = [
  282. (
  283. name,
  284. verifying_key,
  285. sigencode_string(
  286. *sigdecode_der(sig, verifying_key.curve.order),
  287. order=verifying_key.curve.order
  288. ),
  289. )
  290. for name, verifying_key, sig in keys_and_sigs
  291. if not isinstance(verifying_key.curve.curve, CurveEdTw)
  292. ]
  293. """
  294. Name of the curve+hash combination, VerifyingKey and signature as a
  295. byte string.
  296. """
  297. keys_and_string_sigs += [
  298. (
  299. name,
  300. verifying_key,
  301. sig,
  302. )
  303. for name, verifying_key, sig in keys_and_sigs
  304. if isinstance(verifying_key.curve.curve, CurveEdTw)
  305. ]
  306. @settings(**slow_params)
  307. @given(st_fuzzed_sig(keys_and_string_sigs))
  308. def test_fuzzed_string_signatures(params):
  309. verifying_key, sig = params
  310. with pytest.raises(BadSignatureError):
  311. verifying_key.verify(sig, example_data, sigdecode=sigdecode_string)